fix(python): release GIL before blocking on tokio runtime#450
Merged
Conversation
Wrap all rt.block_on() calls in py.detach() to release the GIL before blocking. This prevents deadlock when tool callbacks call Python::attach() to reacquire the GIL in multi-threaded scenarios. Fixed in: PyBash::execute_sync, PyBash::reset, BashTool::execute_sync, BashTool::reset, ScriptedTool::execute_sync. https://claude.ai/code/session_01WZjYqxm5xMPAEe7FSHJkDy
chaliy
force-pushed
the
claude/fix-413-Y2nIj
branch
from
8959128 to
e4e3508
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rt.block_on()calls withpy.detach()to release GIL before blockingPyBash::execute_sync,PyBash::reset,BashTool::execute_sync,BashTool::reset,ScriptedTool::execute_syncCloses #413
Test plan
ScriptedTool,Bash, andBashToolvalidate no deadlockcargo clippyandcargo fmtpasscargo test -p bashkit-pythonpasses